I think upgrades are more luck of the draw than anything else. Our first time of the Pride in 02, we were upgrade 3 times before we got our final cabin. Twice while on board and finding out our assigned room was already booked and the people had checked in.
We have not been upgraded on any of our other cruises. When a ship is full it is hard to change your cabin.